Ticket #450 (closed task: fixed)

Opened 2 years ago

Last modified 2 years ago

Remove illegal variable names

Reported by: anonymous Assigned to: mekstran
Priority: blocker Milestone: Goanna release 0.5
Component: Goanna Version: SVN HEAD
Keywords: Cc:
Blocking:

Description

Names prefixed with an underscore are reserved in the global namespace, we have a few which should be removed.

Additionally, it may be wise to remove our _foo member convention, as that could lead to confusion.

Change History

04/03/07 18:46:40 changed by mekstran

  • status changed from new to assigned.
  • summary changed from Remove illegal member names to Remove illegal variable names.

04/03/07 18:47:28 changed by mekstran

Another thing to remove: our modification of the std namespace for the SGI extensions.

04/03/07 20:30:29 changed by mekstran

(In [1908]) References #450. Removed all globals beginning with _.

04/03/07 20:40:07 changed by mekstran

(In [1910]) References #450. Removed more _ declarations.

04/03/07 20:46:23 changed by mekstran

(In [1912]) References #450. Made the SGI STL extension import stop trampling on the std namespace.

04/03/07 21:40:14 changed by mekstran

(In [1915]) Merged revisions 1908,1910,1912 via svnmerge from svn+ssh://sss/sss/svn/goanna/trunk, and made appropriate conflict resolutions.

........

r1908 | mekstran | 2007-04-03 14:30:28 -0500 (Tue, 03 Apr 2007) | 2 lines

References #450. Removed all globals beginning with _.

........

r1910 | mekstran | 2007-04-03 14:40:06 -0500 (Tue, 03 Apr 2007) | 2 lines

References #450. Removed more _ declarations.

........

r1912 | mekstran | 2007-04-03 14:46:22 -0500 (Tue, 03 Apr 2007) | 2 lines

References #450. Made the SGI STL extension import stop trampling on the std namespace.

........

04/03/07 21:59:46 changed by mekstran

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [1916]) Closes #450. Changed all members to use name_ rather than _name.

04/03/07 22:30:41 changed by mekstran

(In [1917]) Merged revisions 1916 via svnmerge from svn+ssh://sss/sss/svn/goanna/trunk

........

r1916 | mekstran | 2007-04-03 15:59:43 -0500 (Tue, 03 Apr 2007) | 2 lines

Closes #450. Changed all members to use name_ rather than _name.

........

04/06/07 21:36:28 changed by bshearer

(In [1941]) References #450 With the move of SavedObject? code to its own files, some fixes to the member variable names were excluded. This indicates the completion of that fix for the new SavedObject? files.

04/20/07 23:45:01 changed by mekstran

(In [2001]) Merged revisions 1864-1869,1872-1886,1888-1891,1893-1914,1916,1918,1920-1975,1977-1995,1997-2000 via svnmerge from svn+ssh://sss/sss/svn/goanna/branches/saved-objects-everywhere

Merged the renames, etc. that Brandon did into the trunk. #445 will progress from here, probably with a new branch.

........

r1864 | bshearer | 2007-03-23 17:57:57 -0500 (Fri, 23 Mar 2007) | 1 line

References #445. Branch to implement using SavedObjects? everywhere in the Model.

........

r1891 | mekstran | 2007-03-28 10:28:01 -0500 (Wed, 28 Mar 2007) | 3 lines

Blocked revisions 1882-1884 via svnmerge

........

r1941 | bshearer | 2007-04-06 15:36:27 -0500 (Fri, 06 Apr 2007) | 1 line

References #450 With the move of SavedObject? code to its own files, some fixes to the member variable names were excluded. This indicates the completion of that fix for the new SavedObject? files.

........

r1942 | bshearer | 2007-04-06 15:38:51 -0500 (Fri, 06 Apr 2007) | 1 line

Added SavedObject?.h and SavedObject?.cpp to svn

........

r1973 | bshearer | 2007-04-12 15:34:56 -0500 (Thu, 12 Apr 2007) | 1 line

Added to aide in the name changes.

........

r1975 | bshearer | 2007-04-12 16:19:12 -0500 (Thu, 12 Apr 2007) | 1 line

xxxxObjectxxxx related classes names changed to xxxxVObjectxxxx

........

04/28/07 21:05:08 changed by mekstran

(In [2030]) Merged revisions 2001-2003,2005-2017,2019-2021,2023-2029 via svnmerge from svn+ssh://sss.scl.ameslab.gov/sss/svn/goanna/branches/saved-objects-everywhere

References #445.

This merges in the significant refactorings of the saved-objects-everywhere branch; #445 should be finished off as we work on the data manager.

................

r2001 | mekstran | 2007-04-20 17:45:00 -0500 (Fri, 20 Apr 2007) | 31 lines

Merged revisions 1864-1869,1872-1886,1888-1891,1893-1914,1916,1918,1920-1975,1977-1995,1997-2000 via svnmerge from svn+ssh://sss/sss/svn/goanna/branches/saved-objects-everywhere

Merged the renames, etc. that Brandon did into the trunk. #445 will progress from here, probably with a new branch.

........

r1864 | bshearer | 2007-03-23 17:57:57 -0500 (Fri, 23 Mar 2007) | 1 line

References #445. Branch to implement using SavedObjects? everywhere in the Model.

........

r1891 | mekstran | 2007-03-28 10:28:01 -0500 (Wed, 28 Mar 2007) | 3 lines

Blocked revisions 1882-1884 via svnmerge

........

r1941 | bshearer | 2007-04-06 15:36:27 -0500 (Fri, 06 Apr 2007) | 1 line

References #450 With the move of SavedObject? code to its own files, some fixes to the member variable names were excluded. This indicates the completion of that fix for the new SavedObject? files.

........

r1942 | bshearer | 2007-04-06 15:38:51 -0500 (Fri, 06 Apr 2007) | 1 line

Added SavedObject?.h and SavedObject?.cpp to svn

........

r1973 | bshearer | 2007-04-12 15:34:56 -0500 (Thu, 12 Apr 2007) | 1 line

Added to aide in the name changes.

........

r1975 | bshearer | 2007-04-12 16:19:12 -0500 (Thu, 12 Apr 2007) | 1 line

xxxxObjectxxxx related classes names changed to xxxxVObjectxxxx

........

................

r2003 | mekstran | 2007-04-20 17:48:16 -0500 (Fri, 20 Apr 2007) | 2 lines

References #445. Re-branched to resume work on this.

................

r2007 | mekstran | 2007-04-23 12:39:13 -0500 (Mon, 23 Apr 2007) | 3 lines

Initialized merge tracking via "svnmerge" with revisions "1-2002" from svn+ssh://sss/sss/svn/goanna/trunk

................

r2009 | mekstran | 2007-04-24 17:13:48 -0500 (Tue, 24 Apr 2007) | 2 lines

References #445. Buildable but non-functional code to implement properties as saved objects.

................

r2011 | mekstran | 2007-04-26 10:30:02 -0500 (Thu, 26 Apr 2007) | 2 lines

Cleared up a number of segfaults, and fixed the NULL_CHECK_SEGFAULT support. Refs #445.

................

r2012 | mekstran | 2007-04-26 10:33:04 -0500 (Thu, 26 Apr 2007) | 2 lines

Updated a TODO comment.

................

r2013 | mekstran | 2007-04-26 13:27:07 -0500 (Thu, 26 Apr 2007) | 2 lines

Refs #445. Much work towards working-again-ness, but properties still aren't showing up. Time to head in a different direction to try fix them.

................

r2014 | mekstran | 2007-04-27 13:56:06 -0500 (Fri, 27 Apr 2007) | 2 lines

A highly broken refactor of the NodeViewer to attempt to comprehend it. Bugfixes now needed!

................

r2015 | mekstran | 2007-04-27 13:59:35 -0500 (Fri, 27 Apr 2007) | 2 lines

Finishes off [2014], it was missing a file.

................

r2020 | mekstran | 2007-04-27 17:08:46 -0500 (Fri, 27 Apr 2007) | 2 lines

Some good work towards solidifying the new NodeViewer layout.

................

r2021 | mekstran | 2007-04-27 17:25:40 -0500 (Fri, 27 Apr 2007) | 2 lines

Minor formatting tweak.

................

r2024 | mekstran | 2007-04-28 12:52:07 -0500 (Sat, 28 Apr 2007) | 2 lines

Re-connected add node button.

................

r2025 | mekstran | 2007-04-28 13:01:09 -0500 (Sat, 28 Apr 2007) | 2 lines

some minor node-viewer glade tweaks.

................

r2026 | mekstran | 2007-04-28 13:56:53 -0500 (Sat, 28 Apr 2007) | 2 lines

Refs #445. Fixed many bugs, including the no-network-devices bug and some get_status bugs.

................

r2027 | mekstran | 2007-04-28 14:30:01 -0500 (Sat, 28 Apr 2007) | 2 lines

More bugfixes! This refactoring and such is going fairly well.

................

r2028 | mekstran | 2007-04-28 14:36:33 -0500 (Sat, 28 Apr 2007) | 2 lines

Makes selection changes bail when no device is displayed in the NetworkDeviceViewer.

................

r2029 | mekstran | 2007-04-28 14:56:23 -0500 (Sat, 28 Apr 2007) | 2 lines

Refs #445. Some initial work on a child_objects.

................